Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toast): render html correctly #180

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

mohd-azaan
Copy link
Contributor

when html string is used in the toast problem appears

WhatsApp Image 2024-09-09 at 21 43 32_7a488e5b

in the toast.vue component the title and text are using text interpolation so instead of using text interpolation using v-html directive we can avoid the issue

image

Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for frappeui ready!

Name Link
🔨 Latest commit 474261b
🔍 Latest deploy log https://app.netlify.com/sites/frappeui/deploys/670f92730d5f9d00082240f4
😎 Deploy Preview https://deploy-preview-180--frappeui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surajshetty3416 surajshetty3416 changed the title Fix: render html correctly fix: render html correctly Oct 16, 2024
@surajshetty3416 surajshetty3416 changed the title fix: render html correctly fix(toast): render html correctly Oct 16, 2024
@surajshetty3416 surajshetty3416 merged commit a366e16 into frappe:main Oct 16, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants