Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if today_button is defined before use it #437

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

thomasync
Copy link
Contributor

No description provided.

@safwansamsudeen
Copy link
Collaborator

Thanks!

@safwansamsudeen safwansamsudeen merged commit b834da1 into frappe:master Sep 19, 2024
@thomasync thomasync deleted the fix-today-button branch September 19, 2024 14:12
@mantou568
Copy link

this.$today_button.style.left = ${t.left + 20}px``

There is also a lack of judgment here, otherwise when today_futton is false, if the button does not exist here, an error will be reported

@safwansamsudeen
Copy link
Collaborator

@mantou568 this is the code:

if (this.$today_button) {
    this.$today_button.style.left = `${containerRect.left + 20}px`;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants