chore: formatting and test fixes

lending/hooks.py

@@ -132,7 +132,7 @@
 	],
 	"monthly_long": [
 		"lending.loan_management.doctype.process_loan_interest_accrual.process_loan_interest_accrual.process_loan_interest_accrual_for_demand_loans",
-		"lending.loan_management.doctype.process_loan_restructure_limit.process_loan_restructure_limit.calculate_monthly_restructure_limit"
+		"lending.loan_management.doctype.process_loan_restructure_limit.process_loan_restructure_limit.calculate_monthly_restructure_limit",
 	],
 }
 

lending/loan_management/doctype/days_past_due_log/days_past_due_log.py

@@ -6,4 +6,4 @@
 
 
 class DaysPastDueLog(Document):
-	pass
+	pass

lending/loan_management/doctype/days_past_due_log/test_days_past_due_log.py

@@ -6,4 +6,4 @@
 
 
 class TestDaysPastDueLog(FrappeTestCase):
-	pass
+	pass

lending/loan_management/doctype/loan/loan.py

@@ -12,6 +12,7 @@
 import erpnext
 from erpnext.accounts.doctype.journal_entry.journal_entry import get_payment_entry
 from erpnext.controllers.accounts_controller import AccountsController
+
 from lending.loan_management.doctype.loan_security_unpledge.loan_security_unpledge import (
 	get_pledged_security_qty,
 )
@@ -136,7 +137,7 @@ def update_draft_schedule(self):
 					"repayment_start_date": self.repayment_start_date,
 					"posting_date": self.posting_date,
 					"loan_amount": self.loan_amount,
-					"monthly_repayment_amount": self.monthly_repayment_amount
+					"monthly_repayment_amount": self.monthly_repayment_amount,
 				}
 			)
 			schedule.save()
@@ -871,4 +872,4 @@ def move_unpaid_interest_to_suspense_ledger(
 		)
 
 		jv.flags.ignore_mandatory = True
-		jv.submit()
+		jv.submit()

lending/loan_management/doctype/loan/loan_dashboard.py

@@ -18,4 +18,4 @@ def get_data():
 			{"items": ["Loan Repayment", "Loan Interest Accrual", "Loan Write Off", "Loan Restructure"]},
 			{"items": ["Loan Security Unpledge", "Days Past Due Log", "Journal Entry", "Sales Invoice"]},
 		],
-	}
+	}

lending/loan_management/doctype/loan_application/loan_application.py

@@ -259,4 +259,4 @@ def get_proposed_pledge(securities):
 
 	proposed_pledges["maximum_loan_amount"] = maximum_loan_amount
 
-	return proposed_pledges
+	return proposed_pledges

lending/loan_management/doctype/loan_application/test_loan_application.py

@@ -26,8 +26,7 @@ def setUp(self):
 			"Loan Account - _TC",
 			"Interest Income Account - _TC",
 			"Penalty Income Account - _TC",
-			"Repay Over Number of Periods",
-			18,
+			repayment_schedule_type="Monthly as per repayment start date",
 		)
 		self.applicant = make_employee("kate_loan@loan.com", "_Test Company")
 		self.create_loan_application()

lending/loan_management/doctype/loan_asset_classification_range/loan_asset_classification_range.py

@@ -6,4 +6,4 @@
 
 
 class LoanAssetClassificationRange(Document):
-	pass
+	pass

lending/loan_management/doctype/loan_balance_adjustment/loan_balance_adjustment.py

@@ -151,4 +151,4 @@ def make_gl_entries(self, cancel=0, adv_adj=0):
 		gle_map.append(self.get_gl_dict(company_entry))
 
 		if gle_map:
-			make_gl_entries(gle_map, cancel=cancel, adv_adj=adv_adj, merge_entries=False)
+			make_gl_entries(gle_map, cancel=cancel, adv_adj=adv_adj, merge_entries=False)

lending/loan_management/doctype/loan_charge_reference/loan_charge_reference.py

@@ -6,4 +6,4 @@
 
 
 class LoanChargeReference(Document):
-	pass
+	pass

lending/loan_management/doctype/loan_charges/loan_charges.py

@@ -6,4 +6,4 @@
 
 
 class LoanCharges(Document):
-	pass
+	pass

lending/loan_management/doctype/loan_disbursement/loan_disbursement.py

@@ -335,4 +335,4 @@ def get_disbursal_amount(loan, on_current_security_price=0):
 
 
 def get_maximum_amount_as_per_pledged_security(loan):
-	return flt(frappe.db.get_value("Loan Security Pledge", {"loan": loan}, "sum(maximum_loan_value)"))
+	return flt(frappe.db.get_value("Loan Security Pledge", {"loan": loan}, "sum(maximum_loan_value)"))

lending/loan_management/doctype/loan_disbursement/loan_disbursement_dashboard.py

@@ -6,4 +6,4 @@ def get_data():
 				"items": ["Loan Security Deposit"],
 			},
 		],
-	}
+	}

lending/loan_management/doctype/loan_interest_accrual/loan_interest_accrual.py

@@ -379,4 +379,4 @@ def get_per_day_interest(principal_amount, rate_of_interest, posting_date=None):
 
 	return flt(
 		(principal_amount * rate_of_interest) / (days_in_year(get_datetime(posting_date).year) * 100)
-	)
+	)

lending/loan_management/doctype/loan_interest_accrual/test_loan_interest_accrual.py

@@ -243,4 +243,4 @@ def setup_asset_classification_ranges(company):
 			},
 		)
 
-	company_doc.save()
+	company_doc.save()

lending/loan_management/doctype/loan_repayment/loan_repayment.py

@@ -9,6 +9,7 @@
 import erpnext
 from erpnext.accounts.general_ledger import make_gl_entries
 from erpnext.controllers.accounts_controller import AccountsController
+
 from lending.loan_management.doctype.loan.loan import update_all_linked_loan_customer_npa_status
 from lending.loan_management.doctype.loan_interest_accrual.loan_interest_accrual import (
 	get_last_accrual_date,
@@ -1207,4 +1208,4 @@ def get_outstanding_invoices(loan, posting_date):
 			"due_date": ("<=", posting_date),
 		},
 		fields=["name as voucher_no", "outstanding_amount"],
-	)
+	)

lending/loan_management/doctype/loan_repayment_schedule/loan_repayment_schedule.py

@@ -172,4 +172,4 @@ def get_monthly_repayment_amount(loan_amount, rate_of_interest, repayment_period
 		)
 	else:
 		monthly_repayment_amount = math.ceil(flt(loan_amount) / repayment_periods)
-	return monthly_repayment_amount
+	return monthly_repayment_amount

lending/loan_management/doctype/loan_repayment_schedule/test_loan_repayment_schedule.py

@@ -6,4 +6,4 @@
 
 
 class TestLoanRepaymentSchedule(FrappeTestCase):
-	pass
+	pass

lending/loan_management/doctype/loan_restructure/loan_restructure.py

@@ -6,6 +6,7 @@
 from frappe.utils import add_days, cint, flt, getdate
 
 from erpnext.controllers.accounts_controller import AccountsController
+
 from lending.loan_management.doctype.loan.loan import (
 	update_all_linked_loan_customer_npa_status,
 	update_watch_period_date_for_all_loans,
@@ -733,4 +734,4 @@ def create_loan_repayment(loan, posting_date, repayment_type, waiver_amount, res
 	repayment.amount_paid = waiver_amount
 	repayment.loan_restructure = restructure_name
 	repayment.save()
-	repayment.submit()
+	repayment.submit()

lending/loan_management/doctype/loan_restructure/loan_restructure_dashboard.py

@@ -7,4 +7,4 @@ def get_data():
 		"transactions": [
 			{"items": ["Loan Repayment Schedule", "Loan Repayment"]},
 		],
-	}
+	}

lending/loan_management/doctype/loan_restructure/test_loan_restructure.py

@@ -6,4 +6,4 @@
 
 
 class TestLoanRestructure(FrappeTestCase):
-	pass
+	pass

lending/loan_management/doctype/loan_restructure_limit_log/loan_restructure_limit_log.py

@@ -6,4 +6,4 @@
 
 
 class LoanRestructureLimitLog(Document):
-	pass
+	pass

lending/loan_management/doctype/loan_restructure_limit_log/test_loan_restructure_limit_log.py

@@ -6,4 +6,4 @@
 
 
 class TestLoanRestructureLimitLog(FrappeTestCase):
-	pass
+	pass

lending/loan_management/doctype/loan_security_deposit/loan_security_deposit.py

@@ -6,4 +6,4 @@
 
 
 class LoanSecurityDeposit(Document):
-	pass
+	pass

lending/loan_management/doctype/loan_security_deposit/test_loan_security_deposit.py

@@ -6,4 +6,4 @@
 
 
 class TestLoanSecurityDeposit(FrappeTestCase):
-	pass
+	pass

lending/loan_management/doctype/process_asset_classification/process_asset_classification.py

@@ -37,4 +37,4 @@ def create_process_asset_classification(
 	asset_classification.loan = loan
 	asset_classification.previous_process = previous_process[0].name if previous_process else None
 	asset_classification.payment_reference = payment_reference
-	asset_classification.submit()
+	asset_classification.submit()

lending/patches.txt

@@ -6,4 +6,4 @@ lending.patches.v15_0.generate_loan_repayment_schedule
 [post_model_sync]
 # Patches added in this section will be executed after doctypes are migrated
 lending.patches.v15_0.update_loan_types
-lending.patches.v15_0.create_custom_fields
+lending.patches.v15_0.create_custom_fields #6

lending/patches/v15_0/create_custom_fields.py

@@ -2,4 +2,4 @@
 
 
 def execute():
-	after_install()
+	after_install()