Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cancel disbursement with gl cancel #211

Closed
wants to merge 1 commit into from
Closed

fix: cancel disbursement with gl cancel #211

wants to merge 1 commit into from

Conversation

Nihantra-Patel
Copy link

Issue:

  • When canceling a Loan Disbursement, the associated GL Entries were not being canceled correctly. This caused discrepancies in the accounting records, as the GL entries remained active even though the disbursement was reversed.

image

image

Fix:

  • Remove the if not cancel condition. when a Loan Disbursement is canceled, the related GL entries are also canceled. The logic now creates a reverse entry or marks the original entry as canceled, based on the state of the disbursement.

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

Assignees
No one assigned
Labels
needs-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nihantra-Patel @deepeshgarg007