feat: Add Loan Product doctype. #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosue
requested review from
deepeshgarg007 and
anandbaburajan
as code owners
bosue
force-pushed
the
loan_product
branch
2 times, most recently
from
73d4581
to
acdd2eb
Compare
This was referenced Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really just 70% of a minimum viable product, and as usual, for the remaining 30% it will still need quite some love.
But here‘s a first preliminary PR with the Loan Product doctype below Loan Type, as outlined in the original issue #53.
Screenshot of the refactored Loan Type, supposed to give the product manager features, options and boundaries to work with:
Screenshot of the Loan Product, supposed to be maintained by the product manager, who may pick and choose from the given options within the given boundaries:
Still needs work though.
Also please note that the Table MultiSelect widget‘s performance seems to be awful. We could decide to not use it, but both frappe and lending do need a simple m:n relationship model. So what we want is getting the performance issues fixed in frappe/frappe.
Fixes #53, once ready.