Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(agent-job-notifications): Handle more error types #2401

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

balamurali27
Copy link
Contributor

  • fix(agent-job-notifications): Handle can't connect to mysql errs
  • chore(subscription): Correct spelling
  • fix(agent-job-notification): Handle corrupt backup restore attempts
  • fix(agent-job-notification): Handle incompatible backup errs

fixes #2363

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 37.93103% with 18 lines in your changes missing coverage. Please review.

Project coverage is 38.52%. Comparing base (1798667) to head (574b138).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...press/doctype/agent_job/agent_job_notifications.py 37.50% 15 Missing ⚠️
press/press/doctype/site/site.py 0.00% 2 Missing ⚠️
press/press/doctype/agent_job/agent_job.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2401      +/-   ##
==========================================
- Coverage   38.54%   38.52%   -0.02%     
==========================================
  Files         377      377              
  Lines       29252    29286      +34     
==========================================
+ Hits        11274    11282       +8     
- Misses      17978    18004      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@balamurali27 balamurali27 merged commit 65b8ad7 into master Jan 2, 2025
7 of 8 checks passed
@balamurali27 balamurali27 deleted the agent-job-notifs branch January 2, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add agent job notifications for invalid backup traceback
1 participant