fix: update key bindings logic as per new Structure #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After Multi page refactor, key bindings logic was not working as expected. There was a check which would return if target was not document.body but that was incorrect as we changed Structure of canvas area.
|
🎉 This PR is included in version 1.4.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
maharshivpatel
added a commit
to maharshivpatel/print_designer
that referenced
this pull request
Sep 19, 2024
not sure why but i believe focus element is different in some cases which is causing keybinding to not work so reverted changes from frappe#344.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After Multi page refactor, key bindings logic was not working as expected. There was a check which would return if target was not document.body but that was incorrect as we changed Structure of canvas area.