Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomEvent observer for render event (waitForJSEvent) #132

Closed
codecounselor opened this issue Nov 17, 2016 · 0 comments
Closed

CustomEvent observer for render event (waitForJSEvent) #132

codecounselor opened this issue Nov 17, 2016 · 0 comments
Assignees
@codecounselor
Labels
enhancement
Milestone
1.1.0

Comments

@codecounselor
Copy link
Collaborator

Some applications may contain certain display logic that results in the page layout changing from an primary layout (i.e. portrait) to a secondary one (i.e. landscape).

Electron PDF should support this by allowing clients to register an observer for the CustomEvent.detail object when listening to the IPC channel from the browser.

The observer will be invoked before the page is captured

The API must also contain a new function to allow arguments set during construction to be updated with new values.
@codecounselor codecounselor added this to the 1.1.0 milestone Nov 17, 2016
@codecounselor codecounselor self-assigned this Nov 17, 2016
codecounselor pushed a commit to codecounselor/electron-pdf that referenced this issue Nov 17, 2016
removed window resize logic, not ready yet fraserxu#132
c173b12
codecounselor pushed a commit to codecounselor/electron-pdf that referenced this issue Nov 17, 2016
standardjs fraserxu#132
a3b57ff
@codecounselor codecounselor mentioned this issue Nov 17, 2016
Merged
codecounselor pushed a commit to codecounselor/electron-pdf that referenced this issue Nov 21, 2016
refactoring, removed window references in events because it felt wron…
f58a805 
…g and there is no use case for it yet fraserxu#132
codecounselor pushed a commit to codecounselor/electron-pdf that referenced this issue Nov 21, 2016
refactoring, removed window references in events because it felt wron…
6c45f03 
…g and there is no use case for it yet fraserxu#132
codecounselor pushed a commit to codecounselor/electron-pdf that referenced this issue Nov 21, 2016
fixed documentation in README fraserxu#132
06c3497
codecounselor added a commit that referenced this issue Nov 21, 2016
@codecounselor
Issue 132 (#133)
4d8b36b 
* Added event observer and argument mutation
* refactoring, removed window references in events because it felt wrong and there is no use case for it yet #132
* fixed documentation in README #132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codecounselor codecounselor

Labels
enhancement
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
1 participant
@codecounselor