Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Memory Management #163

Closed
codecounselor opened this issue Feb 8, 2017 · 0 comments
Closed

Improve Memory Management #163

codecounselor opened this issue Feb 8, 2017 · 0 comments
Assignees
@codecounselor
Labels
enhancement
Milestone
1.1.7

Comments

@codecounselor
Copy link
Collaborator

Things can go wrong and jobs can terminate abruptly. If the caller does not get a reference to the job back or does not invoke job.destroy() windows can remain open indefinitely. This results in memory leaks as the process continues to run.

Windows that remain open beyond a specified threshold should be automatically terminated. Subsequently, the owning job should also be freed up for garbage collection.

There should be a new event that clients can observe when this happens
@codecounselor codecounselor self-assigned this Feb 8, 2017
codecounselor pushed a commit to codecounselor/electron-pdf that referenced this issue Feb 8, 2017
hung window cleanup, improved code docs. Fixes fraserxu#163
643ee78
@codecounselor codecounselor added this to the 1.1.5 milestone Feb 8, 2017
codecounselor pushed a commit to codecounselor/electron-pdf that referenced this issue Feb 8, 2017
document units for timed constants fraserxu#163
726d28e
@codecounselor codecounselor reopened this Feb 9, 2017
codecounselor pushed a commit to codecounselor/electron-pdf that referenced this issue Feb 9, 2017
Fixes fraserxu#163; Created new windowMaid.js and tested it to ensure…
42fe1af 
… more robust window destruction. Destroyed windows can remain in memory, so that needs to be inspected. Also allow clients to remove windows from the cache explicitly fraserxu#163
codecounselor pushed a commit to codecounselor/electron-pdf that referenced this issue Feb 9, 2017
naming fraserxu#163
93c8c8e
codecounselor pushed a commit to codecounselor/electron-pdf that referenced this issue Feb 10, 2017
object literal instead of static functions fraserxu#163
61162a4
@codecounselor codecounselor modified the milestones: 1.1.7, 1.1.5 Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codecounselor codecounselor

Labels
enhancement
Projects
None yet
Milestone
1.1.7
Development

No branches or pull requests
1 participant
@codecounselor