Skip to content

Commit

Permalink
Re-enable the gazelle linter
Browse files Browse the repository at this point in the history
I don't understand exactly what's going on with the Go package
mirroring. For some reason gazelle doesn't want to mirror the
flatbuffers package. Possibly because we already have it defined in
our workspace. Not sure. There's some magic somewhere that I don't
have insight into. Regardless, we should explicitly point gazelle at
our vendored version of flatbuffers. That's what this patch
accomplishes.

I think this was caused by
google/flatbuffers#7756 or
google/flatbuffers#7720, but I'm not sure. At
least the timing matches.

This patch effectively reverts
Ibd850b77987625d359a38bf53d7db4ae9bc77dc2.

Signed-off-by: Philipp Schrader <philipp.schrader@gmail.com>
Change-Id: I489d2150811bd00ab810a3038bbac2d0dc74ff6d
  • Loading branch information
philsc committed Jan 8, 2023
1 parent dbed683 commit bfa88db
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
1 change: 1 addition & 0 deletions BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ exports_files([
# gazelle:go_generate_proto false
# gazelle:exclude third_party
# gazelle:exclude external
# gazelle:resolve go github.com/google/flatbuffers/go @com_github_google_flatbuffers//go:go_default_library
# gazelle:resolve go github.com/phst/runfiles @com_github_phst_runfiles//:go_default_library
# gazelle:resolve go github.com/frc971/971-Robot-Code/build_tests/fbs //build_tests:test_go_fbs
# gazelle:resolve go github.com/frc971/971-Robot-Code/scouting/webserver/requests/messages/error_response //scouting/webserver/requests/messages:error_response_go_fbs
Expand Down
11 changes: 5 additions & 6 deletions tools/lint/run-ci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,11 @@ git_status_is_clean() {
# All the linters that we are going to run.
readonly -a LINTERS=(
gofmt
# TODO(phil): Re-enable these. No idea what's going on.
#gomod
#update_go_repos
#gazelle
#tweak_gazelle_go_deps
#clean_up_go_mirrors
gomod
update_go_repos
gazelle
tweak_gazelle_go_deps
clean_up_go_mirrors
rustfmt
cargo_lockfile
cargo_raze
Expand Down

0 comments on commit bfa88db

Please sign in to comment.