Reverse order of approve-enable #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If our approval made the PR mergeable (aka "clean status"), then enabling auto-merge fails. This should actually be the case often, but we usually succeed because we do the two actions so quickly. Presumably, GitHub's own state has not updated yet. Sometimes it does, and we see an error about it. Reversing the order of operations will produce the same outcome, but should guarantee the PR is not in clean status when we enable auto-merge (since it is waiting for our own Approve). Fixes #15.
|
✔️ If all status checks pass, and no other reviews are submitted, mergeabot will merge this PR after 5 day(s), on 2024-10-09. As long as that's OK, no other action is necessary. |
|
✔️ If all status checks pass, and no other reviews are submitted, mergeabot will merge this PR the next time it runs. As long as that's OK, no other action is necessary. |
joris974
reviewed
Oct 4, 2024
Co-authored-by: Joris Buchou <joris@freckle.com>
joris974
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If our approval made the PR mergeable (aka "clean status"), then
enabling auto-merge fails.
This should actually be the case often, but we usually succeed because
we do the two actions so quickly. Presumably, GitHub's own state has not
updated yet. Sometimes it does, and we see an error about it.
Reversing the order of operations will produce the same outcome, but
should guarantee the PR is not in clean status when we enable auto-merge
(since it is waiting for our own Approve).
Fixes #15.