Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use clap::helpers::Host #37

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Use clap::helpers::Host #37

merged 1 commit into from
Oct 16, 2023

Conversation

Trinitou
Copy link
Contributor

@Trinitou Trinitou commented Oct 15, 2023 •
edited
Loading

Attention:

  • the main thread check in getExtension got lost
  • the host->_plugin pointer check of the former fromHost method got lost

Mind the other current PRs:

@Trinitou
Refactor* using clap::helpers::Host
fa84cd2 
*but not perfectly
  - the main thread check in getExtension got lost
  - the host->_plugin pointer check of the former fromHost method got lost
@abique abique merged commit 320df35 into free-audio:main Oct 16, 2023
@Trinitou Trinitou deleted the clap_helpers_host branch October 16, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Trinitou @abique