Fix for #40 #43
Merged
Fix for #40 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for free-audio#40 Guard against null _plugin within PluginHost::loadNativePluginPreset Follow error convention in source code Tested arch: arm64 Confirm no longer crash
|
Thanks! |
NatureIsFrequency
added a commit
to NatureIsFrequency/clap-host
that referenced
this pull request
Feb 9, 2024
Per @Trinitou suggestions, a plugin specific menu item should only be enabled (available to execute by user) This fixes the underlying cause of the crashes reported in free-audio#40 and free-audio#42 Therefore this also reverts the now obsolete change in previous merged pull request free-audio#43 Upon load change we update the menu items Tab indentation set to 3 to be consistent with existing code Note: Follows the QT memory ownership model, and the QAction pointers lifetime is handled by their parents Testing: Launch with no plugin loaded, see menu items are greyed out (disabled), user cannot select these items (as intended) therefore code is not executed and app doesn't crash Launch with plugin loaded, see menu items are available and executed when user clicks, and confirm still no crashes Images taken for testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #40
Guard against null _plugin within PluginHost::loadNativePluginPreset
Follow error convention in source code
Tested arch: arm64
Confirm no longer crash