Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new question in general-cs-quiz and update modal-response #357

Merged
merged 8 commits into from
Oct 14, 2022

Conversation

humsarika
Copy link
Contributor

Checklist:

Closes
issue #29

Copy link
Contributor Author

@humsarika humsarika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdwilkin4, I've removed two linux-quiz question from security-quiz.

This PR is also solving issue which was asked to do in PR #355

Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Please review the requested changes.
Once those changes have been implemented, then we can merge your PR into main. 👍

src/data/general-cs-quiz.ts Outdated Show resolved Hide resolved
I've removed the requested question from this file.
@humsarika
Copy link
Contributor Author

@jdwilkin4 , I have done the requested changes.

Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on another contribution to our repository. 🎉
We look forward to future contributions. 👍

@jdwilkin4 jdwilkin4 merged commit 3b2798b into freeCodeCamp:main Oct 14, 2022
@humsarika
Copy link
Contributor Author

@jdwilkin4 Thank you so much for merging my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants