Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a CS question in full-quiz.js #37

Merged
merged 4 commits into from
Jan 25, 2022
Merged

Added a CS question in full-quiz.js #37

merged 4 commits into from
Jan 25, 2022

Conversation

kalashjain23
Copy link
Contributor

@kalashjain23 kalashjain23 commented Jan 25, 2022 •
edited by jdwilkin4
Loading

Checklist:

#29

jdwilkin4
jdwilkin4 requested changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @kalashjain23 !

I think your question looks good.
Just had a small suggestion below. 👍

src/data/full-quiz.js Outdated Show resolved Hide resolved
@kalashjain23
Copy link
Contributor Author

Thanks @jdwilkin4 for that suggestion!!😁 I have made the required changes..

jdwilkin4
jdwilkin4 approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@jdwilkin4 jdwilkin4 merged commit 3bab535 into freeCodeCamp:main Jan 25, 2022
@jdwilkin4
Copy link
Contributor

Hi @kalashjain23 !

Thank you for your quiz question!
We look forward to future contributions 👍

@kalashjain23 kalashjain23 deleted the ques branch January 25, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdwilkin4 jdwilkin4 jdwilkin4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kalashjain23 @jdwilkin4