Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): block intro - go to first lesson button link #55626

Merged
merged 1 commit into from
Jul 24, 2024
Merged

fix(client): block intro - go to first lesson button link #55626

merged 1 commit into from
Jul 24, 2024

Conversation

gikf
Copy link
Member

@gikf gikf commented Jul 23, 2024

Checklist:

@gikf gikf added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. scope: UI Threads for addressing UX changes and improvements to user interface platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. labels Jul 23, 2024
@gikf gikf requested a review from a team as a code owner July 23, 2024 16:56
@moT01
Copy link
Member

moT01 commented Jul 23, 2024 •
edited
Loading

lol. For some more clarification...

-Go to one of the block intro pages, e.g: https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/review-algorithmic-thinking-by-building-a-dice-game/
-Click the "Go to the first lesson" button at the bottom
-You get taken to https://www.freecodecamp.org/strange-place 🤔

moT01
moT01 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

naomi-lgbt
naomi-lgbt approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NGL, I kinda wanna host Zork on /strange-place. Seems fitting.

@naomi-lgbt naomi-lgbt merged commit f3dc9dd into freeCodeCamp:main Jul 24, 2024
35 checks passed
@gikf gikf deleted the fix/go-to-first-lesson-button-link branch July 24, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moT01 moT01 moT01 approved these changes

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

Assignees
No one assigned
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: UI Threads for addressing UX changes and improvements to user interface status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gikf @moT01 @naomi-lgbt