Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use URL constructor #328

Merged
merged 4 commits into from
Nov 20, 2023
Merged

refactor: use URL constructor #328

merged 4 commits into from
Nov 20, 2023

Conversation

ojeytonwilliams
Copy link
Contributor

Checklist:

The main point of this change is that trailing slashes are handled automatically. i.e. new URL('path', "http://domain.name/") and new URL('path', "http://domain.name") are the same.

@ojeytonwilliams ojeytonwilliams requested a review from a team as a code owner November 13, 2023 12:12
sidemt
sidemt approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@sidemt sidemt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I didn't even know there was such a constructor available. LGTM 👍

@ojeytonwilliams ojeytonwilliams merged commit 38e899e into freeCodeCamp:main Nov 20, 2023
@ojeytonwilliams ojeytonwilliams deleted the refactor/use-URL-constructor branch November 20, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidemt sidemt sidemt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ojeytonwilliams @sidemt