feat: upload images from fs not URLs #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not entirely sure if we should include the API url in the src of the image elements as they might change. Let me know what you guys think. |
ojeytonwilliams
requested changes
Nov 16, 2023
I'm not sure. The simplest approach is probably just to store the full URL and, if that changes, handle that separately. e.g. update the db or put in redirects to the new location. @raisedadead any thoughts? |
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
ojeytonwilliams
previously approved these changes
Nov 16, 2023
|
This PR was ready to merge, but the lint check is now failing after I tried resolving the merge conflicts... Asking for help in the team chat. |
sidemt
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)Closes #259