Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: hide pages in drawer #339

Merged
merged 3 commits into from
Nov 20, 2023
Merged

chore: hide pages in drawer #339

merged 3 commits into from
Nov 20, 2023

Conversation

Sembauke
Copy link
Member

@Sembauke Sembauke commented Nov 17, 2023 •
edited
Loading

Checklist:

Closes #331

@Sembauke Sembauke requested a review from a team as a code owner November 17, 2023 09:18
ojeytonwilliams
ojeytonwilliams requested changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't know when, or even if, this will be re-implemented so I think we can get rid of the comments.

apps/frontend/src/components/nav-menu.jsx Outdated Show resolved Hide resolved
apps/frontend/src/components/nav-menu.jsx Outdated Show resolved Hide resolved
@Sembauke @ojeytonwilliams
Apply suggestions from code review
280c3cf 
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
@ojeytonwilliams ojeytonwilliams enabled auto-merge (squash) November 20, 2023 15:16
@ojeytonwilliams ojeytonwilliams merged commit a693763 into main Nov 20, 2023
@ojeytonwilliams ojeytonwilliams deleted the chore/hide-pages-menu branch November 20, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojeytonwilliams ojeytonwilliams ojeytonwilliams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide Pages menu
2 participants
@Sembauke @ojeytonwilliams