Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use user.id instead of magic numbers #349

Merged
merged 1 commit into from
Nov 21, 2023
Merged

test: use user.id instead of magic numbers #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/backend/tests/app.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ beforeAll(async () => {
const fixtures = await setupFixtures();

// Seed test database
await createTestUsers(fixtures.testUsers);
await createTestTags(fixtures.testTags);
await createTestPosts(fixtures.testPosts);
const users = await createTestUsers(fixtures.testUsers);
const tags = await createTestTags(fixtures.testTags);
await createTestPosts(fixtures.getTestPostsData, users, tags);
});

afterAll(cleanupStrapi);
Expand Down
70 changes: 31 additions & 39 deletions apps/backend/tests/helpers/data.helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,50 +1,42 @@
// helper functions to seed the test database

const createTestUsers = async (testUsers) => {
try {
for (const user of testUsers) {
await strapi.entityService.create("plugin::users-permissions.user", {
data: {
...user,
},
});
}
} catch (e) {
console.error(e);
console.error(e.details.errors);
throw new Error("Failed to create mock users");
}
const editor = await strapi.entityService.create(
"plugin::users-permissions.user",
{ data: testUsers.editor },
);
const contributor = await strapi.entityService.create(
"plugin::users-permissions.user",
{ data: testUsers.contributor },
);

return {
editor,
contributor,
};
};

const createTestTags = async (testTags) => {
try {
for (const tag of testTags) {
await strapi.entityService.create("api::tag.tag", {
data: {
...tag,
},
});
}
} catch (e) {
console.error(e);
console.error(e.details.errors);
throw new Error("Failed to create mock tags");
}
const html = await strapi.entityService.create("api::tag.tag", {
data: testTags.html,
});
const css = await strapi.entityService.create("api::tag.tag", {
data: testTags.css,
});

return {
html,
css,
};
};

const createTestPosts = async (testPosts) => {
try {
for (const post of testPosts) {
await strapi.entityService.create("api::post.post", {
data: {
...post,
},
});
}
} catch (e) {
console.error(e);
console.error(e.details.errors);
throw new Error("Failed to create mock posts");
const createTestPosts = async (generateTestPosts, users, tags) => {
const testPosts = await generateTestPosts(users, tags);

for (const data of testPosts) {
await strapi.entityService.create("api::post.post", {
data,
});
}
};

Expand Down
130 changes: 66 additions & 64 deletions apps/backend/tests/helpers/fixtures.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ const setupFixtures = async () => {
const editor = await getRoleId("Editor");

const fixtures = {
testUsers: [
{
testUsers: {
contributor: {
name: "Contributor User",
slug: "contributor-user",
username: "contributor-user",
Expand All @@ -17,7 +17,7 @@ const setupFixtures = async () => {
connect: [contributor],
},
},
{
editor: {
name: "Editor User",
slug: "editor-user",
username: "editor-user",
Expand All @@ -28,78 +28,80 @@ const setupFixtures = async () => {
connect: [editor],
},
},
],
testTags: [
{
},
testTags: {
html: {
name: "HTML",
slug: "html",
},
{
css: {
name: "CSS",
slug: "css",
},
],
testPosts: [
{
title: "Test Title",
body: "<p>test body</p>",
slug: "test-slug",
publishedAt: new Date("2023-08-30T00:00:00.000Z"),
code_injection_head:
'<script> const fCCOriginalPost = "https://www.freecodecamp.org/news/about/"; </script>',
author: {
connect: [1],
},
getTestPostsData({ editor, contributor }, { html, css }) {
return [
{
title: "Test Title",
body: "<p>test body</p>",
slug: "test-slug",
publishedAt: new Date("2023-08-30T00:00:00.000Z"),
code_injection_head:
'<script> const fCCOriginalPost = "https://www.freecodecamp.org/news/about/"; </script>',
author: {
connect: [contributor.id],
},
tags: {
connect: [html.id, css.id],
},
},
tags: {
connect: [1, 2],
{
title: "test title 2",
body: "<p>test body 2</p>",
slug: "test-slug-2",
publishedAt: new Date("2023-08-30T04:09:32.928Z"),
author: { connect: [contributor.id] },
},
},
{
title: "test title 2",
body: "<p>test body 2</p>",
slug: "test-slug-2",
publishedAt: new Date("2023-08-30T04:09:32.928Z"),
author: { connect: [1] },
},
{
title: "Draft Post",
body: "<p>draft post</p>",
slug: "draft-post",
publishedAt: null,
scheduled_at: null,
author: {
connect: [1],
},
tags: {
connect: [1, 2],
},
},
{
title: "Published Post",
body: "<p>published post</p>",
slug: "published-post",
publishedAt: null,
scheduled_at: null,
author: {
connect: [1],
},
tags: {
connect: [1, 2],
{
title: "Draft Post",
body: "<p>draft post</p>",
slug: "draft-post",
publishedAt: null,
scheduled_at: null,
author: {
connect: [contributor.id],
},
tags: {
connect: [html.id, css.id],
},
},
},
{
title: "Editor's draft post",
body: "<p>This is a post by editor user.</p>",
slug: "editors-draft-post",
publishedAt: null,
author: {
connect: [2],
{
title: "Published Post",
body: "<p>published post</p>",
slug: "published-post",
publishedAt: null,
scheduled_at: null,
author: {
connect: [contributor.id],
},
tags: {
connect: [html.id, css.id],
},
},
tags: {
connect: [1, 2],
{
title: "Editor's draft post",
body: "<p>This is a post by editor user.</p>",
slug: "editors-draft-post",
publishedAt: null,
author: {
connect: [editor.id],
},
tags: {
connect: [html.id, css.id],
},
},
},
],
];
},
};

return fixtures;
Expand Down
Loading