Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update deployment guide #351

Merged
merged 4 commits into from
Nov 22, 2023
Merged

docs: update deployment guide #351

merged 4 commits into from
Nov 22, 2023

Conversation

ojeytonwilliams
Copy link
Contributor

Checklist:

Closes #92

I think this is good enough for now, though we'll need to continue to update it as the deployment gets refined.

@ojeytonwilliams ojeytonwilliams requested a review from a team as a code owner November 22, 2023 09:45
Nirajn2311
Nirajn2311 previously approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@Nirajn2311 Nirajn2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for one thing which is not exactly a needed change for this to be merged.

docs/README.md Outdated Show resolved Hide resolved
@ojeytonwilliams @Nirajn2311
docs: clarify env var language.
16b25a0 
Co-authored-by: Niraj Nandish <nirajnandish@icloud.com>
@Nirajn2311 Nirajn2311 merged commit 839a7c3 into freeCodeCamp:main Nov 22, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nirajn2311 Nirajn2311 Nirajn2311 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Instructions for developers
2 participants
@ojeytonwilliams @Nirajn2311