generated from freeCodeCamp/template
-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add accept invitation endpoint #355
Merged
sidemt
merged 12 commits into
freeCodeCamp:main
from
ojeytonwilliams:feat/add-accept-invitation-endpoint
Nov 27, 2023
Merged
feat: add accept invitation endpoint #355
sidemt
merged 12 commits into
freeCodeCamp:main
from
ojeytonwilliams:feat/add-accept-invitation-endpoint
Nov 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows them to confirm that they've logged in.
Nirajn2311
previously approved these changes
Nov 23, 2023
This was referenced Nov 23, 2023
Nirajn2311
reviewed
Nov 23, 2023
Co-authored-by: Niraj Nandish <nirajnandish@icloud.com>
sidemt
previously approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thank you for all the PRs for improving the invitation flow!
sidemt
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another followup PR (to #343) and only the last two commits are new.
Thanks to @Nirajn2311 for the suggestion to allow any authenticated user to tell the api that they've "accepted the invitation". I had considered extending the
api/auth/auth0/callback
endpoint, but this approach is nicer. It's less likely to break when theusers-permissions
plugin is updated and it keeps the logic separated.Once this is in, we'll need to:
status
to differentiate between active and invited usersWe can probably filter out
new
users, since they'll only have that status after they've been created, but before they've been invited. i.e. a few milliseconds.@sidemt I hijacked
user.status
for the invitation flow, but if this interferes with your plans for that, just let me know and I'll come up with another approach.