-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remaining issues for 0.6.1 #786
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apyrgio
force-pushed
the
2024-04-leftovers
branch
from
April 23, 2024 13:47
b081487
to
11ace5f
Compare
deeplow
reviewed
Apr 24, 2024
deeplow
reviewed
Apr 24, 2024
apyrgio
force-pushed
the
2024-04-leftovers
branch
3 times, most recently
from
April 25, 2024 14:10
06618e5
to
1eb4234
Compare
deeplow
approved these changes
Apr 30, 2024
Add a new script called `sign-assets.py`, which produces the hash of all the Dangerzone assets for a release (Windows/macOS installers, container image), and signs them individually. Also update our RELEASE.md document, to incorporate this script into our release workflow.
Add a section for our end-users in INSTALL.md, that explains how to verify that our Dangerzone assets have been signed by our advertised signing key. This section explains what are the .asc files that users see next to our release assets, and how they can verify each asset individually using GPG. It is heavily inspired by a similar section for OnionShare. Closes #761
Make our collapsible blocks in our instructions more noticeable, by enclosing them in an HTML table (<table>).
Inform users that for specific distros and versions, we install some extra packages (PySide6, conmon), in order to fix some incompatibilities between Dangerzone and the base system. Provide also a link to the source / build instructions for the package, as well as any relevant issues. Fixes #767
Add a note in our release instructions to install Python from python.org. This should fix some incompatibilities with older macOS versions. Refs #471
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix various issues that remain for 0.6.1:
python3-pyside6
/conmon
)Refs #471
Fixes #767
Closes #761
Note
In order to visualize the changes for the verification instructions, reviewers can take into account the following: