Restore setuptools/distutils behavior to that of versions < 50.0 #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chigby
force-pushed
the
setuptools-workaround
branch
3 times, most recently
from
0467965
to
0101362
Compare
Experiencing a problem where `pip install pipenv` yields: ``` SystemError: Parent module 'setuptools' not loaded, cannot perform relative import ``` Fix inspired by: pypa/setuptools#2352
chigby
force-pushed
the
setuptools-workaround
branch
from
0101362
to
8af5149
Compare
Checking to see if this will work with the latest version
chigby
force-pushed
the
setuptools-workaround
branch
4 times, most recently
from
5b9365c
to
0bd2e14
Compare
chigby
changed the title
SaptakS
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experiencing a problem where
pip install pipenvyields:My understanding so far: setuptools version 50.0 was released with this change:
Furthermore, Pipenv always installs the latest version of setuptools within virtualenvs it creates. These facts seem to have combined to cause our package installation to fail at various levels, including the creation of a PIpenv, and the installation of packages within a Pipenv. These result in the error quoted at the top of this PR.
Further reading in setuptools bug reports:
Notably, it seems like this behavior does not affect our builds on more recent versions of ubuntu (STN and SecureDrop.org), and in the case of this repo, the problem is fixed by using setting the environment variable
as mentioned above. Meaning I think we can temporarily use this variable until we move away from the combination of python version and ubuntu version that seem to be causing the problem here.
This pull request applies that environment variable to our Circle CI jobs, but I think other work will be needed to get it working in other parts of our infrastructure.