Issue 411 user profile name #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sssoleileraaa
force-pushed
the
issue-451-update-user-on-auth-success
branch
from
f82668d to
04f47a8
Compare
sssoleileraaa
changed the base branch from
issue-451-update-user-on-auth-success
to
master
sssoleileraaa
force-pushed
the
issue-411-user-profile-name
branch
from
bf2e4c3 to
f795852
Compare
sssoleileraaa
force-pushed
the
issue-411-user-profile-name
branch
from
f795852 to
4740654
Compare
|
(note that #285 is for the additional styling here) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #411 without the ellipsis or hover-over overlay, which I believe @rmol is working on a generic solution for.
Here's an example of what this looks like (without styling) and only a first name:
Here's an example of what this looks like (again, without styling) and with a long first and last name:
Test Plan
Log in to the journalist interface and try setting different names to see initials and fullname change in user profile widget.