Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check that form errors are semantically linked to their triggering inputs (WCAG 3.3.1) #6238

Closed
Tracked by #5972
cfm opened this issue Jan 27, 2022 · 1 comment · Fixed by #6240
Closed
Tracked by #5972

check that form errors are semantically linked to their triggering inputs (WCAG 3.3.1) #6238

cfm opened this issue Jan 27, 2022 · 1 comment · Fixed by #6240
Assignees
Labels
a11y Issues related to accessibility

Comments

@cfm
Copy link
Member

cfm commented Jan 27, 2022

This ticket tracks forms in the Source and Journalist Interfaces and how their validation and error states are conveyed to the user.

Interface Template Form Form-level errors Field-level validation
Source login.html LoginForm flashed.html aria-describedby="login-with-existing-code-name-errors"
Source lookup.html SubmissionForm flashed.html Not possible after
return redirect(f"{url_for('main.lookup')}#flashed")
Journalist account_edit_hotp_secret.html Inline flashed.html Not possible outside of WTForms without refactoring
Journalist admin_add_user.html NewUserForm flashed.html aria-describedby attributes
Journalist admin_edit_hotp_secret.html Inline flashed.html Not possible outside of WTForms without refactoring
Journalist admin_new_user_two_factor.html Inline flashed.html Not possible outside of WTForms without refactoring
Journalist admin.html Inline, action-oriented Not applicable Not applicable
Journalist col.html Inline, action-oriented flashed.html Not applicable
Journalist config.html OrgNameForm preferences_saved_flash.html Not possible after
return redirect(url_for('admin.manage_config') + "#config-orgname")
Journalist config.html LogoForm preferences_saved_flash.html Not possible after
return redirect(url_for("admin.manage_config") + "#config-logoimage")
Journalist config.html SubmissionPreferencesForm preferences_saved_flash.html Not possible after
return redirect(url_for('admin.manage_config') + "#config-preventuploads")
Journalist config.html "Alerts": inline, action-oriented preferences_saved_flash.html Not applicable
Journalist delete.html Inline, action-oriented preferences_saved_flash.html Not applicable
Journalist edit_account.html Inline (multiple) flashed.html Not possible outside of WTForms without refactoring
Journalist index.html Inline, action-oriented flashed.html Not applicable
Journalist login.html Inline flashed.html Undesirable for security reasons
@cfm
Copy link
Member Author

cfm commented Jan 28, 2022

As I've outlined above, further annotations are either not applicable or not possible for most forms as currently implemented in the Journalist and Source Interfaces. #6240 proposes to add them in the one case where they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Issues related to accessibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant