-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds aria-{invalid,describedby}
annotations for WTForms validation errors
#6240
Conversation
ARIA-{INVALID,DESCRIBEDBY}
annotations for WTForms validation errorsaria-{invalid,describedby}
annotations for WTForms validation errors
c7eee30
to
777d7b6
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6240 +/- ##
========================================
Coverage 84.09% 84.10%
========================================
Files 60 60
Lines 4220 4222 +2
Branches 509 509
========================================
+ Hits 3549 3551 +2
Misses 550 550
Partials 121 121
Continue to review full report at Codecov.
|
Thanks for reviewing, @legoktm. I'll revise this week. |
777d7b6
to
d72e0dc
Compare
Thanks for the review, @legoktm. Revised accordingly, including the suggested minor refactoring to Jinja's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, test plan still checks out.
Status
Ready for review
Description of Changes
Closes #6238 (towards #5972) by adding
aria-invalid
andaria-describedby
annotations where possible for validated WTForms-based forms. This is admittedly a pretty minor improvement; see #6238 for details on all the places where even this improvement is either not applicable or not possible in the current interfaces of the Source and Journalist Interfaces.Testing
aria-invalid
and has anaria-describedby
annotation pointing to its validation errors. (These annotations will also be used by assistive tech.)Deployment
No deployment considerations.
Checklist
If you made changes to the server application code:
make lint
) and tests (make test
) pass in the development container