Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore bogus pylint "security" issue #6473

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Jun 1, 2022

Status

Ready for review

Description of Changes

pylint-dev/pylint#5322 describes a crash when
using a specific extension that we don't use, and really isn't a
security issue at all.

Ideally we'd upgrade pylint anyways, but we've fallen a bit behind
and it isn't a trivial version bump.

Testing

  • Run make safety, observe it complains about nothing

Deployment

Any special considerations for deployment? No

Checklist

  • These changes do not require documentation

<pylint-dev/pylint#5322> describes a crash when
using a specific extension that we don't use, and really isn't a
security issue at all.

Ideally we'd upgrade pylint anyways, but we've fallen a bit behind
and it isn't a trivial version bump.
@legoktm legoktm requested a review from a team as a code owner June 1, 2022 18:22
@zenmonkeykstop zenmonkeykstop self-assigned this Jun 1, 2022
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make safety passing, issue indeed looks safe to ignore.

@zenmonkeykstop zenmonkeykstop merged commit b6483a8 into develop Jun 1, 2022
@legoktm legoktm deleted the safety-ignore-45185 branch June 2, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants