Extract jtor shape function into a class #107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making available some of the changes that removes the hard-coded double power shape function and allows arbitrary shape functions.
We can now use
ConstrainPaxisIpArbShapeorConstrainBetapIpArbShapeto constrain the profiles with an arbitraryshape_function. By default, these will use theDoublePowerShapeFunctionbut any class that implements the newProfileShapeFunctioninterface will work.Backwards compatibility ensured by writing the
ConstrainBetapIpandConstrainPaxisIpclasses to point at their arbitrary shape counterpart.Added tests using the existing
test_jtor.pyto ensure these additions replicate the behaviour of the code before these changes.Example 01 updated to use the new classes but I don't think updating all of the examples will be necessary--let me know your thoughts on this.