Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If all currents are fixed, IF statement is needed #71

Merged
merged 1 commit into from
Oct 26, 2022
Merged

If all currents are fixed, IF statement is needed #71

merged 1 commit into from
Oct 26, 2022

Conversation

pabloprf
Copy link
Collaborator

Recent updates in FreeGS had broken the capability to run the solver with all coil currents fixed. A simple IF statement seems to solve this.

bendudson
bendudson approved these changes Oct 26, 2022
View reviewed changes
Copy link
Collaborator

@bendudson bendudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pabloprf Is there a test case we could add so we don't accidentally break this again

@pabloprf
Copy link
Collaborator Author

Thanks @bendudson. This was found by Adam Kuang. I'll work with him to provide a test case

@pabloprf pabloprf merged commit 477be4c into master Oct 26, 2022
@bendudson bendudson deleted the recover_nocontrol branch October 26, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendudson bendudson bendudson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pabloprf @bendudson