-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: IMAS(IDS) via OMAS #94
base: master
Are you sure you want to change the base?
Conversation
This would be a great feature to have. Thanks @kripnerl ! |
I am currently using |
# Conflicts: # requirements.txt
Ok, it seems to me it is ready for review. Please answer me questions I left in #95 . Specifically, please check whether I treat the filamentary coil properly. This implementation is quite minimalistic, but for me, it fulfils most of my needs. One could read a lot of other structures supported by FreeGS (sensors, constraints, equilibrium)... At least reading/saving equilibria is on my todo list. But I assume it can be done in other MR. I will also not be available next week, therefore I will able to implement review comments just after that. |
The first implementation of the first part of the IMAS IDS reader
This pull request server is more for discussion - it is not ready yet. Please let me know what you think about this approach and what should this pull request contains.
OMAS package serves as a thin layer between the IMAS database and the world. It allows interfacing the data to various formats. Therefore, I am using it to implement this code.
TODO:
freegs.Machine
from the IDS.