Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original motivation for this PR (below the dotted line) was invalid - see the discussion on my
uv
issue. However, it may still be useful for development usinguv
.This PR would allow local development using
uv
to avoid theopencv
conflict. Simply runninguv pip install -e.
would resolve our dependencies properly (without conflictingopencv
versions). It would not affect users runninguv pip install freemocap
.This change makes it so running
uv pip install freemocap
doesn't downloadopencv-python
. So, you can run in order:uv venv freemocap-env --python 3.11
source freemocap-env/bin/activate
uv pip install freemocap
freemocap
And have freemocap run without the opencv conflict.
This will get us a non-pyapp based installation option that avoids the opencv conflict entirely, at the cost of substituting
uv venv
forconda create
anduv pip install
forpip install
.Currently not working as intended - I'm going to dig into this further and possibly file an issue with uv. (EDIT: I filed an issue here: astral-sh/uv#9073) It works great using
uv pip install -e.
, and if we can get it to work properly withuv pip install freemocap
, it will be worth changing our default installation method to uv.Testing
uv pip install -e.
: when installing from within the project folder, this works as intended!uv pip install 'freemocap @ /Users/philipqueen/Documents/GitHub/freemocap/'
: when installing from disk (with the correct branch active), this doesn't work.opencv-python
is still downloaded.uv pip install "git+https://github.com/freemocap/freemocap@philip/use_uv"
: when installing from git (on the correct branch), this doesn't work.opencv-python
is still downloaded.