Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steam: default to 5-digit codes #252

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

James-E-A
Copy link

I have confirmed that this fix works.

@James-E-A
Copy link
Author

(The reason for this PR is that Steam's API outputs slightly malformed URIs; however, given that some software interfaces to their API seem reluctant to patch it on their end, and we've already got some Steam-specific monkey-patches, I don't think it'd be too out-of-line to add in one more on our end.)

@James-E-A James-E-A changed the title Steam: use 5-digit codes Steam: default to 5-digit codes Feb 22, 2021
@James-E-A
Copy link
Author

James-E-A commented Feb 22, 2021

Additionally, this PR would bring FreeOTP in line with other authenticators such as andOTP, Kee Vault, and Aegis, all of which have implemented [linked] workarounds to this mistake.

@kevoroid
Copy link

Why is this not being merged and released?

@James-E-A
Copy link
Author

Why is this not being merged and released?

@kevoroid The project dead. For all intents and purposes, FreeOTPPlus has superseded this app; for instance, they merged #113 same-day, and had it released less than 2 weeks later. It also supports many features that this app does not (for instance, master build of this app got rid of manual secret entry… not that one can tell, since the last release was in January of 2016.)

The last non-translation commit to this repo was an API version bump in October 2019.

@kevoroid
Copy link

kevoroid commented Mar 29, 2021

Why is this not being merged and released?

@kevoroid The project dead. For all intents and purposes, FreeOTPPlus has superseded this app; for instance, they merged #113 same-day, and had it released less than 2 weeks later. It also supports many features that this app does not (for instance, master build of this app got rid of manual secret entry… not that one can tell, since the last release was in January of 2016.)

The last non-translation commit to this repo was an API version bump in October 2019.

Such a shame! its a very good and simple app; I offered Redhat to take over and update but they ask for a PR which I know would go nowhere and would be a waste!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants