Separate tokenReceived for Stellar Asset Contract
#139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konnov
approved these changes
Oct 21, 2024
| ): Condition { | ||
| const oldTokenStorage = env.oldStorage(token).persistent() | ||
| const tokenStorage = env.storage(token).persistent() | ||
| return every( |
There was a problem hiding this comment.
would not the && work just as well?
There was a problem hiding this comment.
It would, but using every() allows us to inform the user which conjunct failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a delta to #135.
While working on #133, I realized that Stellar Asset Contracts use a different storage layout than the
soroban-examples/tokencontract (in particular, they keep a struct inside theBalancestorage, not just ani128amount).In this PR, we
tokenTransferredcondition that only applies tosoroban-examples/tokenout of Solarkraft, and intoverify_js_example.tstokenTransferredinsteadtokenReceived, that checks only the receiver part oftokenTransferredtokenReceivedis necessary, because there may not be a sender balance recorded in contract storage of the SAC if the sender is transferring native tokens.