Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Apalache path #145

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Fix Apalache path #145

merged 3 commits into from
Oct 23, 2024

Conversation

thpani
Copy link
Collaborator

@thpani thpani commented Oct 23, 2024

We were looking up apalache-mc under either the custom env variable APALACHE_HOME, or the hardcoded path /opt/apalache. Instead of the hardcoded path, we can simply rely on $PATH to find the binary.

Also improves the error message if spawnSync fails.

Also removes a superfluous slash in the devcontainer Dockerfile.

@thpani thpani requested a review from konnov October 23, 2024 15:32
konnov
konnov approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@konnov konnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix!

@thpani thpani merged commit 8a232b3 into main Oct 23, 2024
3 checks passed
@thpani thpani deleted the th/fix-apalache-path branch October 23, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konnov konnov konnov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
M4: Solarkraft integration with Apala...
Development

Successfully merging this pull request may close these issues.
2 participants
@thpani @konnov