forked from prebid/Prebid.js
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eng 4157 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: new Pubstack Analytics Module * fix: global name * fix: tests * fix: typo
* Add colombia adapter * Add https in the url * update files * add test cases and update md file * remove native from package.json and update colombia test cases * Use conditions for the size * Use conditions for the size and remove test warnings * remove package.json * Resolved import related errors * update referrer method * remove package json and update referer path * revert package json * Resolved all changes * update version package json * Resolved test cases issues
* added support for pubcommon, digitrust, id5id * added support for IdentityLink * changed the source for id5 * added unit test cases * changed source param for identityLink * PubMatic sets bid.adserverTargeting.hb_buyid_pubmatic * documentation note about bid.adserverTargeting.hb_buyid_pubmatic * expect buyid to be in seatbid.ext.buyid
* Add support for bidderRequest.refererInfo in Adhese Adapter. * Add support for bidderRequest.refererInfo in Adhese Adapter. * Jira AD-2462 / add tlall is consent string is present * Added 'adhese' attribute to bid that contains meta data - Jira AD-2642 * added DALE to adhese determination * extra config option: no format, but use size array as format string * Added more values to originData * Revert "Added more values to originData" This reverts commit 57f0033. * Pulled Sander's changes & added more data to originData * Adhese bid adapter - final version Co-authored-by: Mateusz Michalowski <mateusz@adhese.eu> Co-authored-by: Mateusz Michalowski <mateusz@michalowski.biz> Co-authored-by: Tim Sturtewagen <tim@adhese.com> Co-authored-by: Kim Van Crombrugge <kim@adhese.eu> Co-authored-by: Sander <sander@adhese.eu>
* adding DMX test @97%, two files added one updated * Update districtm_spec.js * Update districtmDMX.js * adding all districtm needed file * remove legacy file * remove typo || 0 in the test method * force default to return a valid width and height * update unit test code for failing test * changed class for an object * remove package-lock.json * change file name for dmx adapter * renamed files * restaure package-lock.json * update to last package-lock state * update gdpr user consent * fix sizes issue * Documentation updates Adding the readme.md info * update file name and update unit testing import file location * current machine state * lint correction * remove variable assigment duplicate * adding CCPA support for DMX * adding test for ccpa and gdpr * districtm dmx adding deal id field * idsync support ccpa & gdpr * adding support uid provide tdid id5 pubCommon digitrust Co-authored-by: Steve Alliance <steve@districtm.ca> Co-authored-by: Luis <luissastreverzun@gmail.com> Co-authored-by: Steve Alliance <stevealliance@Steves-Air.localdomain> Co-authored-by: Steve Alliance <stevealliance@Steves-MacBook-Air.local> Co-authored-by: steve-a-districtm <steve@districtm.net>
Co-authored-by: Ignat Khaylov <khaylov@betweenx.com>
* PUBA-5273:initial commit with analytics adapter, spec & md file * PUBA-5273: updated adapter definition * PUBA-5273: added support contact info * PUBA-5273: adding clearInterval on AUCTION_END * PUBA-5273: reverted last commit as CircleCI job failed * Reverted changes to fix CircleCI build error * Re-commiting invocation of clearInterval on Auction_end * PUBA-7575: updating adapter invocation approach * PUBA-7575: updating the formatting * PUBA-7575: updating adapter logic * Updating filter to 50% from 5% * Removing console * Reducing 50% pass to 1% pass rate * Updating commnet * Making PR review changes * Updating the .md file
* Support new aniview bid adapter * Support new aniview bid adapter * Support new aniview bid adapter * Support new aniview bid adapter * Fix Consent parameters * Update aniviewBidAdapter.js V3 support * Update aniviewBidAdapter.js * Update aniviewBidAdapter.js Update refererInfo * Update aniviewBidAdapter.js Fix tabs and spaces * Update aniviewBidAdapter.js fixes * Update aniviewBidAdapter.js * Update aniviewBidAdapter.js Add ccpa support * Update aniviewBidAdapter.js Typo * Update aniviewBidAdapter.js * Update aniviewBidAdapter.js * Fix size and sample Fixed sizes from playerSize Updated md sample * Fix tabs * Fix sizes * Recheck * Add tgt parameter * Update sample * Add support for cookie sync + tests * Add support for cookie sync + tests * Add support for cookie sync + tests
* adding ccpa support for emx_digital adapter * emx_digital ccpa compliance: lint fix * emx 3.0 compliance update * fix outstream renderer issue, update test spec * refactor formatVideoResponse function to use core-js/find Co-authored-by: Nick Colletti <nick.colletti@emxdigital.com> Co-authored-by: Nick Colletti <gnomish@gmail.com> Co-authored-by: Kiyoshi Hara <Kiyoshi.Hara@emxdigital.com>
Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.SYNAPPNXS.local>
…races (prebid#5177) Co-authored-by: Melody Li <melody@yieldmo.com>
* update mock requests * update mutiple bidders request Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.appnexus.com>
* Add Quantumdex Bid Adapter Add Quantumdex Bid Adapter * Update quantumdexBidAdapter.js, quantumdexBidAdapter_spec.js * Update quantumdexBidAdapter.md * Update quantumdexBidAdapter.md * Update quantumdexBidAdapter.js * Update quantumdexBidAdapter.js * Update quantumdexBidAdapter.js
* add gdpr and usp Co-authored-by: atkachov <atkachov91@admixer.ua>
* feat(gdpr) : gdpr support added * tests fixed
* initial * fix * remove redundant language mod, use player sizes in video traff * test modify * fix * Adding Tests Co-authored-by: Aigolkin1991 <Aigolkin1991@gmail.com>
* Livewrapped bid and analytics adapter * Fixed some tests for browser compatibility * Fixed some tests for browser compatibility * Changed analytics adapter code name * Fix double quote in debug message * modified how gdpr is being passed * Added support for Publisher Common ID Module * Corrections for ttr in analytics * ANalytics updates * Auction start time stamp changed * Detect recovered ad blocked requests Make it possible to pass dynamic parameters to adapter * Collect info on ad units receiving any valid bid * Support for ID5 Pass metadata from adapter * Typo in test + eids on wrong level * Fix for Prebid 3.0 * Fix get referer * http -> https in tests * Native support * Read sizes from mediatype.banner * Revert accidental commit * Support native data collection + minor refactorings * Set analytics endpoint * Support for app parameters * Fix issue where adunits with bids were not counted on reload * Send debug info from adapter to external debugger
…rebid#5186) * Add videoCacheKey on the bid object only if the cache url is not set * Added test case for the scenario where we don't manually set the videoCacheKey on purpose when the cache url is present.
* Change publisherId to zoneId Add gdpr Add supply chain Add video media type * Remove comments * Fix unit test coverage * fix request id bug add vastXml to video response * Remove bid response default sizes * Change endpoint url * Add unit test for vastXml * Change end point * Remove trailing-space * Add onBidWon function
* Updates core-js to version 3. * More changes related to updating core-js to version 3 * Updated new files from master to also be compatible with core-js v3. * Updated package-lock.json * Revert "Updated new files from master to also be compatible with core-js v3." This reverts commit b2ae8d9. # Conflicts: # modules/priceFloors.js * Revert "Updates core-js to version 3." This reverts commit a731dce. # Conflicts: # modules/adkernelBidAdapter.js # modules/audienceNetworkBidAdapter.js # modules/emx_digitalBidAdapter.js # modules/widespaceBidAdapter.js # package.json # src/config.js # src/userSync.js # src/utils.js # test/spec/modules/widespaceBidAdapter_spec.js * Updated new files to core-js v3 and imports now end in .js * Import set without .js since set is a module and not a file. * Updated new file from master to also be compatible with core-js v3.
* add Blue Billywig adapter * Blue Billywig Adapter - update according to review feedback * Blue Billywig Adapter - update to try and pass CircleCI * Remove the last for .. of in bluebillywigBidAdapter.js, hopefully... * Update bluebillywigBidAdapter test parameters to match renderer to rendererCode rename Co-authored-by: Klaas-Jan Boon <klaas-janboon@live.nl>
* Adding Konduit module * Removed superfluous arguments passed to obtainVastUrl function * Removed superfluous arguments passed to obtainVastUrl function. * Build trigger (empty commit) * Module documentation updated according to the comments * Logic in obtainVastUrl function updated according to the review comment. * Removed hook, enabled eslint * Merged recent prebid changes * New method is introduced to process a bid and return dynamic CPM data * New Konduit Analytics adapter responsible for client auction stats collection * Updated konduit analytics adapter .md file * Fixed linter issue with more than 1 blank line used * Use '$prebid.version$' instead of the $$PREBID_GLOBAL$$.version * Updated unit tests Co-authored-by: Max Shevchenko <max.shevchenko@sigma.software> Co-authored-by: Alexander Kislitsyn <alexander.kislitsyn@sigmaukraine.com>
Audience Network for prebid has been removed.
* ITDEV-4723 PrebidJS adapter support with SupplyChain module object * ITDEV-4723 Fix tests * ITDEV-4723 New entry point Co-authored-by: veranevera <vera.yukhina@showheroes.com> Co-authored-by: Elizaveta Voziyanova <44549195+h2p4x8@users.noreply.github.com>
Co-authored-by: vedant.s <vedant.s@media.net>
* freewheel-ssp fix issue on playerSize of bidRequest * freewheel-ssp fix issue on playerSize of bidRequest * freewheel add dealId property in bidResponse
* vendorExceptions is a global check * two allowed vars not one duh
* Add microadBidAdapter * Remove unnecessary encodeURIComponent from microadBidAdapter * Submit Advangelists Prebid Adapter * Submit Advangelists Prebid Adapter 1.1 * Correct procudtion endpoint for prebid * analytics update with wrapper name * reverted error merge * update changed default value of netRevenue to true * Re-add rubicon analytics without deprecated getTopWindowUrl util * Cache referrer on auction_init instead of bid_requested * merged remote master changes * Include integration type in video OpenRTB requests Co-authored-by: nakamoto <nakamoto_tatsuya@microad.co.jp> Co-authored-by: Chandra Prakash <chandra.prakash@advangelists.com> Co-authored-by: Isaac Dettman <idettman@rubiconproject.com> Co-authored-by: Eric Harper <eharper@rubiconproject.com> Co-authored-by: TJ Eastmond <teastmond@la-wlandaverde-mac.local> Co-authored-by: Mark Monday <mmonday@rubiconproject.com>
Co-authored-by: mi.chen <mi.chen@criteo.com>
Co-authored-by: Aigolkin1991 <Aigolkin1991@gmail.com>
…#5230) * Add AOL defaults for currency and creative ID until fix issued server-side * Satisfy linter single quotes * Roll back breaking change to utils.parseQueryStringParameters and add a better test to catch this in future * utils.parseQueryStringParameters - add stripping of trailing ampersand to alleviate all tests amended in utils update
…d#5199) * Added banner support for Dynamic Ad Placement (DAP) * updated version number * changed version to 3.0.2 in both adapter and tests _spec * Added DAP Banner test for interpretResponse & isBidRequestValid * Updated DAP tests - video and banner validations * updated adapter examples .md file * Updated ternary operator for bidResponse.mediaType setting * removing redundant display parameter validation * Update package-lock.json
…#5217) * Added TheMediaGridNM Bid Adapter * Updated required params for TheMediaGridNM Bid Adapter * Update TheMediGridNM Bid Adapter * Fix tests for TheMediaGridNM Bid Adapter * Fixes after review for TheMediaGridNM Bid Adapter * Add support of multi-format in TheMediaGrid Bid Adapter
* Update Bidder Code * LunaMedia Adapater LunaMedia Adapater * Updated LunamediaBidAdapter.md test params and valid pub code for testing * Updating User ID submodules to execute callback onError AJAX * fix parrable test when IE * parrable spec all messed up after merge, fixed now Co-authored-by: Chandra Prakash <chandra.prakash@advangelists.com> Co-authored-by: trchandraprakash <47793448+trchandraprakash@users.noreply.github.com> Co-authored-by: rmartinez <Rachael24!>
* Changes video Adapter * Update MD Richaudience Co-authored-by: sgimenez <sergi.gimenez@richaudience.com>
* initial tribeOS bidder adapter commit * initial tests for tribeOS bidder adapter * removed unimplemented "getUserSyncs" function * removed unimplemented "onBidWon" function * tribeOS - change end point URL * force commit * Revert "tribeOS - change end point URL" This reverts commit 680c7d4. * tribeOS - change end point URL * restore .js extensions * fixed issue "newline required at end of file"
* outstream changes * removing global filtet * reverting page * message * adapter change * remove space * testcases * testpage * spaces for test page * renderer exist case * reverting package-lock.json * adding schain object * adding tagid * syntaxx error fix * video.html * space trailing * space * tagid * inventoryId and placement * rewarded video * added unit test case * comment * hp param * test cases * version * .md file * Indention Co-authored-by: Deepthi Neeladri Sravana <dsravana@UNKNOWN-172-154-7-X.yahoo.com> Co-authored-by: Deepthi Neeladri Sravana <dsravana@rav1-1-gci-pool-general-10-87-131-88.corp.yahoo.com> Co-authored-by: Deepthi Neeladri Sravana <dsravana@UNKNOWN-172-142-163-X.yahoo.com> Co-authored-by: Deepthi Neeladri Sravana <dsravana@rav1-1-gci-pool-general-10-87-131-52.corp.yahoo.com> Co-authored-by: Deepthi Neeladri Sravana <dsravana@C02VH0WGHTDG.local> Co-authored-by: Deepthi Neeladri Sravana <dsravana@UNKNOWN-172-142-176-X.yahoo.com> Co-authored-by: Deepthi Neeladri Sravana <dsravana@rav1-1-gci-pool-general-10-87-128-108.corp.yahoo.com> Co-authored-by: Deepthi Neeladri Sravana <dsravana@rav1-1-gci-pool-general-10-87-140-151.corp.yahoo.com> Co-authored-by: Deepthi Neeladri Sravana <dsravana@rav1-1-gci-pool-general-10-87-137-79.corp.yahoo.com> Co-authored-by: Deepthi Neeladri Sravana <dsravana@vpn-pool-142-174-120.snv.office.oath>
* add bid adapter * fix doc * fix endpoint and add user syncs * fix endpoint in tests * send user id and time out * more tests * fix PR feedback * add test bidder param * send test as numeric boolean * add comment about test bid CPM * actually the mime type should be text/plain
* Livewrapped bid and analytics adapter * Fixed some tests for browser compatibility * Fixed some tests for browser compatibility * Changed analytics adapter code name * Fix double quote in debug message * modified how gdpr is being passed * Added support for Publisher Common ID Module * Corrections for ttr in analytics * ANalytics updates * Auction start time stamp changed * Detect recovered ad blocked requests Make it possible to pass dynamic parameters to adapter * Collect info on ad units receiving any valid bid * Support for ID5 Pass metadata from adapter * Typo in test + eids on wrong level * Fix for Prebid 3.0 * Fix get referer * http -> https in tests * Native support * Read sizes from mediatype.banner * Revert accidental commit * Support native data collection + minor refactorings * Set analytics endpoint * Support for app parameters * Fix issue where adunits with bids were not counted on reload * Send debug info from adapter to external debugger * SChain support
…gs to keep consistency between banner and video. (prebid#5240) (cherry picked from commit bc4217b)
nicgallardo
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.