two small fixes #14
Open
two small fixes #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The saturation patch should be harmless, but I'm interested in why saturation is needed at that point. I remember going through this when originally writing the code, and deciding it could never overflow at that point. Is there some example data which causes overflow at this point in the code? It might highlight another issue which leads to the overflow. |
|
As I remember since this patch was created years ago, this fixes a sign error while sine play. Means sign change from plus max to minus max as I remember. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix G722 saturation
fix crosscompile - looking in host dirs