configure.ac: uncomment AC_CANONICAL_BUILD #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit uncomments `AC_CANONICAL_BUILD`. This is needed in order to make cross-compilation work properly (at least in nixpkgs). The `AC_CANONICAL_BUILD` line in `configure.ac` was commented out in 2009 as part of a gigantic megapatch imported from subversion. It is unclear why it was commented out. It appears to make the `if` conditional (the next stanza of code) into deadcode.
ghost
marked this pull request as ready for review
ghost
mentioned this pull request
1 task
7c6f434c
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Mar 9, 2023
This commit adds `autoreconfHook` and cherry-picks a patch submitted upstream in order to fix cross compilation. - freeswitch/spandsp#47
ConnorBaker
pushed a commit
to ConnorBaker/nixpkgs
that referenced
this pull request
Mar 15, 2023
This commit adds `autoreconfHook` and cherry-picks a patch submitted upstream in order to fix cross compilation. - freeswitch/spandsp#47
ElXreno
pushed a commit
to ElXreno/nixpkgs
that referenced
this pull request
Mar 18, 2023
This commit adds `autoreconfHook` and cherry-picks a patch submitted upstream in order to fix cross compilation. - freeswitch/spandsp#47
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit uncomments
AC_CANONICAL_BUILD. This is needed inorder to make cross-compilation work properly (at least in nixpkgs).
The
AC_CANONICAL_BUILDline inconfigure.acwas commented out in2009 as part of a gigantic megapatch imported from subversion. It
is unclear why it was commented out. It appears to make the
ifconditional (the next stanza of code) into deadcode.