Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frmvp 14224 - adding a streaming implementation #120

Merged
merged 3 commits into from
Oct 19, 2021
Merged

Conversation

hayleyfreetrade
Copy link
Contributor

This change is to implement the stream function, since we are now using streaming in the accounting codebase and need to be able to test it.

…ren't previously using the stream function in the code base hence the no implementation.
Copy link
Contributor

@rorybainfreetrade rorybainfreetrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…ntroducing a check that means the implementation and tests aren't run on older versions. This implementation will be used by account-functions (for now), which uses node 12.
@hayleyfreetrade hayleyfreetrade merged commit 510c5c0 into master Oct 19, 2021
@adrinr adrinr deleted the FRMVP-14224 branch April 27, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants