Fix/start after issue #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varsis
force-pushed
the
fix/start-after-issue
branch
from
9f9f73a
to
e017099
Compare
molloyjj
reviewed
Oct 6, 2022
Comment on lines
+286
to
+288
| if (val instanceof InProcessFirestoreDocRef) { | ||
| return val.id | ||
| } |
There was a problem hiding this comment.
How was this being absent causing an infinite loop out of interest?
There was a problem hiding this comment.
val was being cast to a string which was being returned as [Object object] in the following if block
if (val && typeof val.toString === "function") {
val = val.toString()
}
When we passed in a document ref instead of a string value this would occur. When the filtering was happening it was getting "DOCUMENT_ID" and "[Object object]" to compare.
The code I wrote uses the last document to start after, in this case it kept returning the same document over and over again and would never complete.
molloyjj
reviewed
Oct 6, 2022
molloyjj
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.