Merge pull request #694 from freeverseio/fix/e2e-ci-job-condition

Run e2e when approval, merge to main or manual dispatch
freeverseio · Jul 26, 2024 · 4be9138 · 4be9138
2 parents 162c218 + 95791d2
commit 4be9138
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml
@@ -11,7 +11,7 @@ jobs:
     runs-on:
       group: laos
       labels: ubuntu-16-cores
-    if: ${{ github.event.review.state == 'approved' || github.event_name == 'workflow_dispatch' }}
+    if: ${{ github.event_name != 'pull_request_review' || github.event.review.state == 'approved' }}
     steps:
       - uses: actions/checkout@v3
       - uses: ./.github/actions/setup

diff --git a/e2e-tests/tests/test-update-extended-token-uri.ts b/e2e-tests/tests/test-update-extended-token-uri.ts
@@ -25,7 +25,7 @@ describeWithExistingNode("Frontier RPC (Extend Token URI)", (context) => {
 		context.web3.eth.accounts.wallet.add(FAITH_PRIVATE_KEY);
 	});
 
-	let uloc = `universal/location_${Date.now()}`;
+	let uloc = `universal/location/1/${Date.now()}`;
 	let extendResult: any;
 	let tokenURI = "https://example.com";
 
@@ -85,7 +85,7 @@ describeWithExistingNode("Frontier RPC (Extend Token URI)", (context) => {
 describeWithExistingNode("Frontier RPC (Update Extended Token URI)", async (context) => {
 	let contract: Contract;
 
-	let uloc = `universal/location_${Date.now()}`;
+	let uloc = `universal/location/2/${Date.now()}`;
 	let tokenURI = "https://example2.com";
 	let newTokenURI = "https://new.example.com";
 	let updateExtensionResult: any;