Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Polkadot SDK to Stable2407 and Enhance Runtime Configurations #773

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

magecnion
Copy link
Contributor

@magecnion magecnion commented Sep 12, 2024

PR Type

enhancement, dependencies, tests


Description

  • Upgraded the Polkadot SDK dependencies to the stable2407 branch across multiple files, ensuring compatibility with the latest stable release.
  • Enhanced runtime configurations by adding new parameters and simplifying existing configurations in various modules.
  • Suppressed deprecation warnings in the eth and service modules by adding #[allow(deprecated)] attributes.
  • Simplified logic in staking tests and treasury configuration by removing unused parameters and functions.
  • Added a new migration MigrateV4ToV5 to the runtime migrations.
  • Fixed a typo in the E2E test script command in package.json.

Changes walkthrough 📝

Relevant files
Enhancement
10 files
laos.rs
Simplify ChainSpec Type Definition                                             

node/src/chain_spec/laos.rs

  • Simplified the ChainSpec type definition by removing the
    RuntimeGenesisConfig.
  • +1/-2     
    eth.rs
    Suppress Deprecation Warnings in Eth Module                           

    node/src/eth.rs

  • Added #[allow(deprecated)] attribute to suppress deprecation warnings.

  • +2/-0     
    service.rs
    Suppress Deprecation Warnings and Clean Up Service Module

    node/src/service.rs

  • Added #[allow(deprecated)] attribute to suppress deprecation warnings.
  • Removed unused sync_service parameter from functions.
  • +5/-8     
    tests.rs
    Simplify Burn Logic in Staking Tests                                         

    pallets/parachain-staking/src/tests.rs

  • Simplified the reset_issuance function by using a new Balances::burn
    method.
  • +1/-10   
    apis.rs
    Add Initialize Pending Block to Runtime APIs                         

    runtime/laos/src/apis.rs

    • Added initialize_pending_block function to the runtime APIs.
    +4/-0     
    cumulus_xcmp_queue.rs
    Add New Parameters to XCMP Queue Configuration                     

    runtime/laos/src/configs/cumulus_xcmp_queue.rs

  • Added new parameter types MaxActiveOutboundChannels and MaxPageSize.
  • Updated Config implementation to include new parameters.
  • +10/-1   
    treasury.rs
    Simplify Treasury Configuration                                                   

    runtime/laos/src/configs/treasury.rs

  • Removed ProposalBond and ProposalBondMinimum parameters.
  • Simplified the Config implementation by removing unused types.
  • +1/-10   
    xcm_config.rs
    Add XcmRecorder to XCM Configuration                                         

    runtime/laos/src/configs/xcm_config.rs

    • Added XcmRecorder type to the Config implementation.
    +1/-0     
    migrations.rs
    Add V5 Migration to Runtime Migrations                                     

    runtime/laos/src/migrations.rs

  • Added a new migration MigrateV4ToV5.
  • Implemented V5Config for the runtime.
  • +18/-1   
    pallet_treasury.rs
    Remove Unused Treasury Weight Functions                                   

    runtime/laos/src/weights/pallet_treasury.rs

    • Removed weight functions related to proposal handling.
    +0/-45   
    Dependencies
    1 files
    Cargo.toml
    Update Dependencies to Stable2407 Branch                                 

    Cargo.toml

  • Updated dependencies to use the stable2407 branch of the Polkadot SDK.
  • Updated jsonrpsee version to 0.23.2.
  • +140/-140
    Tests
    1 files
    package.json
    Fix Typo in E2E Test Script Command                                           

    e2e-tests/package.json

    • Fixed typo in the test script command.
    +1/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    magecnion and others added 2 commits September 13, 2024 09:27
    …#778)
    
    * using runt 1.77
    
    * fix clippy errors
    
    * fixing clippy
    
    * update to runtime 2200
    
    * update proyect version to 0.22.0
    
    * add missing migration
    
    * removed the upgrade of versioning
    @asiniscalchi asiniscalchi marked this pull request as ready for review September 13, 2024 11:32
    @asiniscalchi
    Copy link
    Member

    /describe

    Copy link

    PR Description updated to latest commit (43737f3)

    @github-actions github-actions bot changed the title Upgrade polkadot-sdk to stable2407 Upgrade Polkadot SDK to Stable2407 and Enhance Runtime Configurations Sep 13, 2024
    @asiniscalchi
    Copy link
    Member

    /describe

    Copy link

    PR Description updated to latest commit (42e3392)

    asiniscalchi
    asiniscalchi previously approved these changes Sep 13, 2024
    Copy link
    Member

    @asiniscalchi asiniscalchi left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Treasury entry disappered
    image

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    Upgrade to Polkadot-SDK 2407
    3 participants