Allow to initialize "pending" blocks in a specific way (add runtime api pending_initialize_block) #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorpaas
approved these changes
Jan 3, 2024
|
@sorpaas @boundless-forest can someone merge this PR? |
boundless-forest
approved these changes
Aug 1, 2024
ipapandinas
pushed a commit
to AstarNetwork/frontier
that referenced
this pull request
Sep 4, 2024
magecnion
added a commit
to freeverseio/laos
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At moonbeam, we necessarily need to initialize "pending" bloks in a different way to classic blocks, because our pallet randomness panics at
on_initializehook if the node doesn't have a VRF key in its keystore.We need to tell our pallet that we're in the context of a "pending" block built by an RPC provider, and not a normal block. Somehow, we need to modify the client/runtime interface to tell the runtime that we're in the context of a "pending" block, the simplest solution we've found is to add a new method to the runtime API
EthereumRuntimeRPCApi.