Fail clippy on warnings, try remove TODO comments #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Apr 8, 2024
| @@ -140,6 +140,7 @@ impl<Api> EthCompatRuntimeApiCollection for Api where | |||
| { | |||
| } | |||
|
|
|||
| #[allow(clippy::too_many_arguments)] | |||
There was a problem hiding this comment.
can be tackled later if someone wants. didn't want to touch critical node code
ghost
commented
Apr 8, 2024
| @@ -154,7 +154,7 @@ impl<T: Config> Pallet<T> { | |||
| error: <Error<T>>::DelegatorBondBelowMin.into(), | |||
| }, | |||
| ); | |||
| let new_amount: BalanceOf<T> = (bonded_amount - decrease_amount).into(); | |||
| let new_amount: BalanceOf<T> = bonded_amount.saturating_sub(decrease_amount); | |||
There was a problem hiding this comment.
this is kinda big deal, I am wondering if there are more instances of using unsafe arithmetic in the staking code
ghost
commented
Apr 8, 2024
| @@ -409,8 +408,9 @@ fn geneses() { | |||
| }); | |||
| } | |||
|
|
|||
| #[allow(unused_imports)] | |||
There was a problem hiding this comment.
this is very weird compiler error, maybe because block_author is used only in tests it always complains that it is unused
ghost
marked this pull request as ready for review
ghost
self-assigned this
|
that's cool |
asiniscalchi
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not all the
TODOcomments are addressed.TODOcomments seem bit complex and more time consumingprecompilesshould be fixed with nextpolkadot-sdk/frontierupgrade to>1.3.0check_on_savewe runclippy_on_save. Sinceclippyalso runscheckunderneath