Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Proxy Configuration with Tests for Pure Proxy Creation and Modification #549

Merged
merged 9 commits into from
Apr 9, 2024

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented Apr 8, 2024

Type

enhancement, tests


Description

  • Added tests to verify the functionality of creating a pure proxy and adding a proxy to it within the proxy configuration.
  • Enhanced the proxy configuration module by including additional utility imports and expanding the test coverage to ensure the correct behavior of proxy creation and modification.

Changes walkthrough

Relevant files
Enhancement
proxy.rs
Add Tests for Creating and Adding Proxies in Pure Proxied
Configuration

runtime/laos/src/configs/proxy.rs

  • Expanded the test module to include tests for creating a pure proxy
    and adding a proxy to a pure proxy.
  • Introduced new imports to support the added tests, including UNIT,
    ExtBuilder, ALICE, BOB, AccountId, and RuntimeOrigin.
  • Added a test create_pure_proxy to verify the creation of a pure proxy.
  • Added a test add_proxy_to_pure_proxy_should_succeed to verify adding a
    proxy to an existing pure proxy.
  • +73/-1   

    PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @asiniscalchi
    Copy link
    Member Author

    /describe

    @asiniscalchi asiniscalchi linked an issue Apr 8, 2024 that may be closed by this pull request
    @github-actions github-actions bot changed the title Fix/add proxy to pure proxied Enhance Proxy Configuration with Tests for Pure Proxy Creation and Modification Apr 8, 2024
    Copy link

    github-actions bot commented Apr 8, 2024

    PR Description updated to latest commit (e3e2414)

    ccubu
    ccubu previously approved these changes Apr 9, 2024
    @asiniscalchi asiniscalchi merged commit c427544 into main Apr 9, 2024
    8 checks passed
    @asiniscalchi asiniscalchi deleted the fix/add_proxy_to_pure_proxied branch April 9, 2024 12:07
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    Inability to Add a New Proxy to a Proxied Account
    3 participants