Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Comprehensive Unit Tests for BlockWeights Configuration #564

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Add Comprehensive Unit Tests for BlockWeights Configuration #564

merged 4 commits into from
Apr 15, 2024

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented Apr 12, 2024 •
edited by github-actions bot
Loading

Type

tests

Description

  • Introduced comprehensive unit tests for the BlockWeights configuration in the primitives module.
  • These tests validate the correctness of base_block, max_block, and per_class weights for different dispatch classes.

Changes walkthrough

Relevant files
Tests
lib.rs
Unit Tests for BlockWeights Configuration                               

primitives/src/lib.rs

  • Added a new test module for BlockWeights.
  • Implemented unit tests for base_block, max_block, and per_class
    weights.
  • Verified the weights for normal, mandatory, and operational dispatch
    classes.
    		• +40/-0   

    ✨ PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @asiniscalchi asiniscalchi marked this pull request as draft April 12, 2024 05:49
    @asiniscalchi
    Copy link
    Member Author

    /describe

    @asiniscalchi asiniscalchi marked this pull request as ready for review April 12, 2024 06:04
    @github-actions github-actions bot changed the title added tests for block_weights Add Comprehensive Unit Tests for BlockWeights Configuration Apr 12, 2024
    @github-actions GitHub Actions
    Copy link

    PR Description updated to latest commit (d66ca91)

    @asiniscalchi asiniscalchi merged commit 9ef7316 into main Apr 15, 2024
    8 checks passed
    @asiniscalchi asiniscalchi deleted the fix/blockweight branch April 15, 2024 12:52
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ccubu ccubu ccubu approved these changes

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @asiniscalchi @ccubu