Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dead code #594

Merged
merged 3 commits into from
May 13, 2024
Merged

remove dead code #594

merged 3 commits into from
May 13, 2024

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented May 13, 2024

PR Type

enhancement, bug_fix


Description

  • Removed the entire migration module which was responsible for runtime upgrades related to precompiles.
  • Removed unnecessary weight modules and imports for pallet_asset_metadata_extender and pallet_laos_evolution, streamlining the codebase.
  • Cleaned up imports in the mod.rs files, removing references to deleted modules.

Changes walkthrough 📝

Relevant files
Enhancement
migration.rs
Remove Migration Precompile Module                                             

runtime/laos/src/precompiles/migration.rs

  • Entire file removed which contained code for injecting precompiled
    bytecode during runtime upgrades.
  • +0/-78   
    mod.rs
    Remove Migration Module Import                                                     

    runtime/laos/src/precompiles/mod.rs

    • Removed the migration module import.
    +0/-2     
    mod.rs
    Cleanup Weight Modules Imports                                                     

    runtime/laos/src/weights/mod.rs

  • Removed imports for pallet_asset_metadata_extender and
    pallet_laos_evolution weight modules.
  • +0/-2     
    pallet_asset_metadata_extender.rs
    Remove Autogenerated Weights for Asset Metadata Extender 

    runtime/laos/src/weights/pallet_asset_metadata_extender.rs

  • Entire file removed which contained autogenerated weights for the
    pallet_asset_metadata_extender.
  • +0/-71   
    pallet_laos_evolution.rs
    Remove Autogenerated Weights for Laos Evolution                   

    runtime/laos/src/weights/pallet_laos_evolution.rs

  • Entire file removed which contained autogenerated weights for the
    pallet_laos_evolution.
  • +0/-121 

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @asiniscalchi
    Copy link
    Member Author

    /describe

    Copy link

    PR Description updated to latest commit (06af9d3)

    @asiniscalchi
    Copy link
    Member Author

    @asiniscalchi asiniscalchi marked this pull request as draft May 13, 2024 12:57
    @asiniscalchi asiniscalchi marked this pull request as ready for review May 13, 2024 13:15
    @@ -764,6 +764,7 @@ construct_runtime!(
    }
    );

    #[allow(dead_code)] // https://github.com/moonbeam-foundation/moonbeam/blob/26a88a553563647992f39fbd1cce3d45a363e991/runtime/moonbeam/src/lib.rs#L1585-L1614
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    shall we add these links to the issue on the github project for future reference?

    @asiniscalchi asiniscalchi merged commit cde946b into main May 13, 2024
    8 checks passed
    @asiniscalchi asiniscalchi deleted the fix/clippy_with_new_rust branch May 13, 2024 13:31
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants