Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pallet evm weights #609

Merged
merged 8 commits into from
May 31, 2024
Merged

pallet evm weights #609

merged 8 commits into from
May 31, 2024

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented May 31, 2024 •
edited by github-actions bot
Loading

PR Type

Enhancement

Description

  • Updated benchmark dates and host information across multiple pallets.
  • Adjusted weight values, proof size estimates, and execution times for various functions in parachain staking, vesting, proxy, multisig, utility, sudo, and XCMP queue pallets.
  • Updated storage proof details to reflect new benchmarks.
  • Modified the WeightInfo type for the EVM pallet configuration.

Changes walkthrough 📝

Relevant files
Enhancement
pallet_parachain_staking.rs
Update weights and benchmarks for parachain staking pallet

runtime/laos/src/weights/pallet_parachain_staking.rs

  • Updated benchmark dates and host information.
  • Adjusted weight values for various functions.
  • Modified proof size estimates and execution times.
  • Updated storage proof details.
    		•  +204/-204
    pallet_vesting.rs
    Update weights and benchmarks for vesting pallet                 

    runtime/laos/src/weights/pallet_vesting.rs

  • Updated benchmark dates and host information.
  • Adjusted weight values for vesting functions.
  • Modified proof size estimates and execution times.
  • Updated storage proof details.
    		•  +64/-64 
    pallet_proxy.rs
    Update weights and benchmarks for proxy pallet                     

    runtime/laos/src/weights/pallet_proxy.rs

  • Updated benchmark dates and host information.
  • Adjusted weight values for proxy functions.
  • Modified proof size estimates and execution times.
  • Updated storage proof details.
    		•  +57/-59 
    pallet_multisig.rs
    Update weights and benchmarks for multisig pallet               

    runtime/laos/src/weights/pallet_multisig.rs

  • Updated benchmark dates and host information.
  • Adjusted weight values for multisig functions.
  • Modified proof size estimates and execution times.
  • Updated storage proof details.
    		•  +39/-39 
    pallet_utility.rs
    Update weights and benchmarks for utility pallet                 

    runtime/laos/src/weights/pallet_utility.rs

  • Updated benchmark dates and host information.
  • Adjusted weight values for utility functions.
  • Modified proof size estimates and execution times.
    		•  +18/-18 
    pallet_sudo.rs
    Update weights and benchmarks for sudo pallet                       

    runtime/laos/src/weights/pallet_sudo.rs

  • Updated benchmark dates and host information.
  • Adjusted weight values for sudo functions.
  • Modified proof size estimates and execution times.
    		•  +8/-8     
    cumulus_pallet_xcmp_queue.rs
    Update weights and benchmarks for XCMP queue pallet           

    runtime/laos/src/weights/cumulus_pallet_xcmp_queue.rs

  • Updated benchmark dates and host information.
  • Adjusted weight values for XCMP queue functions.
  • Modified proof size estimates and execution times.
    		•  +6/-6     
    evm.rs
    Update EVM pallet configuration for weight info                   

    runtime/laos/src/configs/evm.rs

    • Updated the WeightInfo type for the EVM pallet configuration.
    		 +1/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @asiniscalchi
    Copy link
    Member Author

    /describe

    @github-actions GitHub Actions
    Copy link

    PR Description updated to latest commit (e8fbbcd)

    @asiniscalchi
    Copy link
    Member Author

    /describe

    @github-actions GitHub Actions
    Copy link

    PR Description updated to latest commit (da5d3ce)

    @asiniscalchi asiniscalchi marked this pull request as ready for review May 31, 2024 08:57
    @asiniscalchi asiniscalchi linked an issue May 31, 2024 that may be closed by this pull request
    Calculate weights of EVM pallet #604
    Closed
    @asiniscalchi asiniscalchi changed the title Feature/pallet evm weights pallet evm weights May 31, 2024
    ccubu
    ccubu reviewed May 31, 2024
    View reviewed changes
    runtime/laos/src/benchmarks.rs Outdated Show resolved Hide resolved
    runtime/laos/src/benchmarks.rs
    [pallet_vesting, Vesting]
    [pallet_session, SessionBench::<Runtime>] // TODO check why SessionBench::<Runtime>
    [pallet_parachain_staking, ParachainStaking]
    [cumulus_pallet_xcmp_queue, XcmpQueue]
    [pallet_evm, EVM]
    [pallet_laos_evolution, LaosEvolution]
    [pallet_asset_metadata_extender, AssetMetadataExtender]
    // [pallet_laos_evolution, LaosEvolution]
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Out of curiosity why our pallets don't have to compute weights?

    Copy link
    Member Author

    @asiniscalchi asiniscalchi May 31, 2024 •
    edited
    Loading

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    it something we are going to handle in #584

    @asiniscalchi asiniscalchi merged commit e048990 into main May 31, 2024
    8 checks passed
    @asiniscalchi asiniscalchi deleted the feature/pallet_evm_weights branch May 31, 2024 10:17
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ccubu ccubu ccubu approved these changes

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Calculate weights of EVM pallet
    2 participants
    @asiniscalchi @ccubu