Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring precompiles to use macros #624

Merged
merged 67 commits into from
Jun 18, 2024
Merged

Refactoring precompiles to use macros #624

merged 67 commits into from
Jun 18, 2024

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented Jun 12, 2024 •
edited by github-actions bot
Loading

PR Type

Enhancement, Tests

Description

  • Refactored Evolution Collection precompile implementation to use macros.
  • Added new precompile functions for minting, evolving, and ownership transfer.
  • Implemented gas cost recording and error handling.
  • Added new legacy precompile implementation.
  • Added and refactored tests for Evolution Collection and legacy precompiles.
  • Updated mock configuration to use new precompile structure.

Changes walkthrough 📝

Relevant files
Tests
tests.rs
Refactor and add tests for Evolution Collection precompiles.

precompile/evolution-collection/src/tests.rs

  • Replaced MockPrecompileSet with LaosPrecompiles.
  • Updated function calls to use new PrecompileCall and
    FactoryPrecompileCall.
  • Added new tests for various precompile functions.
  • Refactored existing tests to use new precompile structure.
    		•  +225/-318
    tests.rs
    Add tests for legacy evolution collection precompiles.     

    precompile/evolution-collection-legacy/src/tests.rs

  • Added new test file for legacy evolution collection precompiles.
  • Implemented tests for minting, evolving, and ownership transfer.
    		•  +681/-0 
    tests.rs
    Add and refactor tests for Laos Evolution pallet.               

    pallets/laos-evolution/src/tests.rs

  • Added tests for slot and owner to token ID conversion.
  • Updated tests to use new Slot type.
  • Refactored existing tests for minting and evolving.
    		•  +43/-78 
    mock.rs
    Update mock configuration for Evolution Collection precompiles.

    precompile/evolution-collection/src/mock.rs

  • Updated mock configuration to use new precompile structure.
  • Added new type definitions for PrecompileCall and
    FactoryPrecompileCall.
    		•  +40/-60 
    Enhancement
    lib.rs
    Refactor Evolution Collection precompile with macros.       

    precompile/evolution-collection/src/lib.rs

  • Refactored precompile implementation to use macros.
  • Added new precompile functions for minting, evolving, and ownership
    transfer.
  • Implemented gas cost recording and error handling.
    		•  +211/-252
    lib.rs
    Implement legacy Evolution Collection precompile.               

    precompile/evolution-collection-legacy/src/lib.rs

  • Added new legacy precompile implementation.
  • Implemented functions for minting, evolving, and ownership transfer.
    		•  +374/-0 

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    asiniscalchi and others added 22 commits June 11, 2024 11:17
    @asiniscalchi
    init step
    62e9cf4
    @asiniscalchi
    added EVM standard precompiles to new pattern
    cc5de7a
    @asiniscalchi
    creating params into evm config
    64dbbfc
    @asiniscalchi
    compiles without collection precompile handling
    cafb919
    @asiniscalchi
    minimal
    cfeb2ef
    @asiniscalchi
    starting point
    89d1516
    @magecnion
    add callable fn to precompile
    e90dc75
    @asiniscalchi
    step for disctiminant
    98a2047
    @asiniscalchi
    first discriminatn implementation
    4736545
    @asiniscalchi
    first view function
    119182f
    @asiniscalchi
    evulution collection legacy
    4ddb619
    @magecnion
    add mock and test owner selector
    60239bc
    @asiniscalchi
    legacy
    7648bf3
    @magecnion
    Merge remote-tracking branch 'origin/feature/first_precompile_with_ma…
    9ce3043 
    …cros' into test/owner_call_from_precompile
    @magecnion
    add owner test
    1c0d1f4
    @asiniscalchi
    fix compilation
    85c0fa6
    @magecnion
    Merge remote-tracking branch 'origin/feature/first_precompile_with_ma…
    3e41e93 
    …cros' into test/owner_call_from_precompile
    @magecnion
    WIP
    45c69fe
    @magecnion
    cargo fmt
    979fc69
    @magecnion
    add pallet_evm_laos_evolution_collection_factory boilderplate
    57b75b2
    @asiniscalchi
    reactive all e2e tests
    6031647
    @asiniscalchi
    removed test:laos
    5c09b38
    @asiniscalchi
    Copy link
    Member Author

    /describe

    @github-actions GitHub Actions
    Copy link

    PR Description updated to latest commit (5c09b38)

    @asiniscalchi
    Copy link
    Member Author

    /describe

    @github-actions GitHub Actions
    Copy link

    PR Description updated to latest commit (01910a7)

    @asiniscalchi asiniscalchi changed the title Feature/first precompile with macros Refactoring precompiles to use macros Jun 18, 2024
    @asiniscalchi asiniscalchi marked this pull request as ready for review June 18, 2024 10:56
    @asiniscalchi
    Copy link
    Member Author

    /describe

    @github-actions GitHub Actions
    Copy link

    PR Description updated to latest commit (e3fb42d)

    @asiniscalchi asiniscalchi merged commit eb8fc0e into main Jun 18, 2024
    8 checks passed
    @asiniscalchi asiniscalchi deleted the feature/first_precompile_with_macros branch June 18, 2024 13:33
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @magecnion magecnion magecnion approved these changes

    @ccubu ccubu ccubu approved these changes

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @asiniscalchi @magecnion @ccubu