Refactor and enhance evolution collection precompile with tests and new functionalities #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rimenting_with_benchmarks
|
/describe |
|
PR Description updated to latest commit (9055c58) |
luispdm
reviewed
Jun 25, 2024
| type AccountStore = System; | ||
| type RuntimeHoldReason = (); | ||
| type DustRemoval = (); | ||
| type WeightInfo = (); |
There was a problem hiding this comment.
Another suggestion, no need to implement it in this PR. To avoid redeclaring types for every mock and runtime, you can use the with_default macro together with the TestDefaultConfig in the laos-evolution pallet. There's an example in the polkadot-sdk: https://github.com/paritytech/polkadot-sdk/blob/3c213726cf165d8b1155d5151b9c548e879b5ff8/substrate/frame/sudo/src/lib.rs#L152-L185
There was a problem hiding this comment.
good point with_default is very handy ... let's try to use it in a refactor in a new PR
…ate_collection_gas
…iles' into estimate_create_collection_gas
luispdm
previously approved these changes
Jun 26, 2024
* poc * fmt * fmt * better assert * better assert * better assert * better comments * update weights using runtime benchmarking
|
I suggest taking a look at #633 which adds some test and missing runtime weights. It could complement your changes and add value |
Include gas estimation for `create collection` and `owner`
magecnion
approved these changes
Jun 26, 2024
luispdm
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement, Tests
Description
pallet_laos_evolution.Changes walkthrough 📝
tests.rs
Refactor and enhance precompile tests with new functionalities.precompile/evolution-collection/src/tests.rs
create_collectionandmintfunctions to useEvmDataWriter.tests.rs
Add comprehensive tests for evolution collection precompile.pallets/laos-evolution/src/precompiles/evolution_collection/tests.rs
handling.
MockHandleandEvmDataWriterfor test setup.tests.rs
Refactor and enhance precompile factory tests with newfunctionalities.precompile/evolution-collection-factory/src/tests.rs
lib.rs
Implement new precompile actions and refactor existing functions.precompile/evolution-collection/src/lib.rs
Actionenum for function selectors.Precompiletrait forEvolutionCollectionPrecompile.EvmDataWriterandLogsBuilder.revert_dispatch_error.weights.rs
Update autogenerated weights for pallet_laos_evolution.pallets/laos-evolution/src/weights.rs
pallet_laos_evolution.mod.rs
Add new precompile set for evolution collection.pallets/laos-evolution/src/precompiles/evolution_collection/mod.rs
EvmDataWriterandLogsBuilderfor function implementation.mod.rs
Update module visibility in runtime configuration.runtime/laos/src/configs/mod.rs
evmandlaos_evolutionmodules public.